ci: use ctest - #8439
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
| run: | | ||
| set -o pipefail | ||
| ./vortex-ffi/build/test/vortex_ffi_test 2>&1 | rustfilt | ||
| ctest --test-dir vortex-ffi/build -N |
There was a problem hiding this comment.
We've already built the binary
Merging this PR will improve performance by 18.47%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
273.6 ns | 215.3 ns | +27.1% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
333.9 ns | 275.6 ns | +21.17% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
456.9 ns | 398.6 ns | +14.63% |
| ⚡ | Simulation | encode_varbin[(1000, 2)] |
175.3 µs | 157.1 µs | +11.6% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ji/clean-rust-intru (741703b) with develop (e935986)
Footnotes
-
10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
| set -o pipefail | ||
| ./vortex-ffi/build/test/vortex_ffi_test 2>&1 | rustfilt | ||
| ctest --test-dir vortex-ffi/build -N | ||
| ctest --test-dir vortex-ffi/build --output-on-failure --timeout 120 -V 2>&1 | rustfilt |
There was a problem hiding this comment.
ctest convolutes the output on errors, so I'd not do this
myrrc
left a comment
myrrc
left a comment
There was a problem hiding this comment.
I don't think we should merge this
2 participants
This seems better